Cli overhaul: snapshot #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deprecated all the snapshot functions and added new ones. As the qemu in the function name implies it doesn't work for LXC.
Adding a command that allows for all setting to be used regarding snapshots
the implementation of building the tree structure in FormatSnapshotsTree() can probably be inproved.
Renamed ValidateIDset() to RequiredIDset() and added a description to the function. Changed the indexPos to uint as this value should never be negative.
frostyfab
pushed a commit
to frostyfab/proxmox-api-go
that referenced
this pull request
Nov 17, 2023
Cli overhaul: snapshot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another pull for #171
Work so far:
list snapshotsto a json tree and list depending on the--no-treeflag(test *Test) StandardTest(t *testing.T) (out []byte)to be able to return the json output for more advanced processing.